WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix "hda lost interrupt issue" on PAE host

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix "hda lost interrupt issue" on PAE host
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 20 Apr 2006 08:31:15 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 20 Apr 2006 00:56:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <FFEFE1749526634699CD3AC2EDB7627A0192A6F5@pdsmsx406>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <FFEFE1749526634699CD3AC2EDB7627A0192A6F5@pdsmsx406>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 20 Apr 2006, at 02:23, Jiang, Yunhong wrote:

Hi, Keir
This patch fix the “hda lost interrupt” issue when create vmx guest on PAE host.
 
Signed-off-by: Yunhong Jiang Yunhong.jiang@xxxxxxxxx
Signed-off-by: Eddie Dong eddie.dong@xxxxxxxxx
 

It'd be nice to have some description of *how* the patch fixes the bug. I'd like to have some idea what the purpose of the piece of code you move around is: what's the difference between IDT-vectoring exception info and ordinary VM-exit exception info? Why is reflecting the info back into VM-entry fields always the right thing to do? etc. In general, patches that appear to simply shuffle code around worry me.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel