This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Oops from loop driver on IA64

To: Kouya SHIMURA <kouya@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Oops from loop driver on IA64
From: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Date: Tue, 18 Apr 2006 13:49:21 +0300
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Alex Williamson <alex.williamson@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 18 Apr 2006 03:49:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200604181041.k3IAfsi07036@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200604181041.k3IAfsi07036@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Tue, Apr 18, 2006 at 07:41:55PM +0900, Kouya SHIMURA wrote:

> I investigated this and might find a serious bug.
> On x86, flush_dcache_page() does nothing and there is no problem.
> But on ia64 flush_dcache_page() might access a wrong page struct
> and destroy the kernel memory.
> Attached patch fixes this problem but it seems bad idea to modify
> a linux driver. How should we fix it?

Adding ifdefs to drivers is definitely not the right thing do do from
an upstream inclusion point of view. Can you define
flush_dcache_page() to be a NOP or some other reasonable definition
when running under Xen?


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>