This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH][RESEND] only BSP can really do clear_all_shadow_

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH][RESEND] only BSP can really do clear_all_shadow_status
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Sun, 16 Apr 2006 03:05:07 +0800
Cc: xen-devel Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sat, 15 Apr 2006 12:05:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZgp7YcJFDEJqkHQJCC85BNK/f39gAFS33A
Thread-topic: [PATCH][RESEND] only BSP can really do clear_all_shadow_status
>On 15 Apr 2006, at 15:54, Li, Xin B wrote:
>> only BSP can really do clear_all_shadow_status.
>> This fixes SMP IA32 VMX guest booting on IA32 xen.
>Why can only VCPU0 do this? Is the argument to 
>clear_all_shadow_status() always current domain? If so that should 
>probably be asserted, or the argument removed.

Both Jun and I think clear_all_shadow_status is overkilled,
update_pagetables should have done the cleanup things, so we thought
about removing it, but the test shows that removing it breaks windows on
PAE xen, and I'm looking at this issue.

Actually, this patch should be a right direction, and changeset 9626 has
alrealdy changed shadow.c like what this patch does to shadow32.c.

For long term, maybe we will move to per vcpu shadow.


>  -- Keir

Xen-devel mailing list