This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] libxc whitespace

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] libxc whitespace
From: Muli Ben-Yehuda <mulix@xxxxxxxxx>
Date: Sat, 15 Apr 2006 17:47:35 +0300
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Hollis Blanchard <hollisb@xxxxxxxxxx>
Delivery-date: Sat, 15 Apr 2006 07:48:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060415143006.GA10863@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1145045311.8498.13.camel@xxxxxxxxxxxxxxxxxxxxx> <20060415074753.GX10412@xxxxxxxxxxxxxxxxxxx> <20060415143006.GA10863@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060126
On Sat, Apr 15, 2006 at 03:30:06PM +0100, John Levon wrote:
> On Sat, Apr 15, 2006 at 10:47:53AM +0300, Muli Ben-Yehuda wrote:
> > > tools/libxc. This patch, a result of running
> > >   perl -p -i -e 's/\s+$/\n/g' tools/libxc/*.[ch]
> > 
> > Could we just run this on the entire Xen and tools trees?
> No, can't we wait and do this a file at a time when other changes are
> made? It is far from critical and it makes merging hell...

I agree it makes merging hell, but hopefully, it will merging hell
once and after that something automatic will enforce it at check-in
time the same way akpm does for -mm, and all will be well with the
world. The strategy you suggest almost always ends up with people
making both changes at once, which makes *reviewing* hell.

Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>