This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [rfc] "frame number" size in hypercall ABI

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: [Xen-devel] Re: [rfc] "frame number" size in hypercall ABI
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 15 Apr 2006 09:57:02 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sat, 15 Apr 2006 01:57:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: Your message of "Fri, 14 Apr 2006 14:19:59 CDT." <1145042400.8498.2.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> Because the patch is so invasive, I'm now thinking it might be better to
> define a new GETMEMLIST2 dom0 op that uses the new frameno_t type and a
> new xc_get_pfn_list2() wrapper for it. Since PowerPC will need a new
> xc_linux_build.c anyways, that will call xc_get_pfn_list2(), leaving all
> the current "unsigned long" code in place for the x86 and ia64 paths. As
> PowerPC starts implementing features like ptrace, migration,
> libxendebug, we'll need to move over those call chains.
> Thoughts?

I would like to avoid introducing new dom0_ops. If an invasive change
is only changing longs into an equivalent typedef'ed long (on x86/ia64)
then it's not hard to reason that it's correct. If it also causes
changes in users of libxc then well, that's a shame, but it's not
fixed by introducing a new dom0_op unless you duplicate every end user
for the ppc architecture too. :-)

 -- Keir

Xen-devel mailing list