This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: console bug fixes

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: console bug fixes
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Thu, 13 Apr 2006 14:05:11 +0100
Delivery-date: Thu, 13 Apr 2006 06:02:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <443E57F2.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200604131058.04195.Tristan.Gingold@xxxxxxxx> <443E57F2.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Jeudi 13 Avril 2006 13:53, Jan Beulich a écrit :
> While I realize this was done that way before, I'd recommend not storing
> zeroes when clearing a line, but rather spaces with a proper attribute
> (which will make the console better cooperate with dom0-s potentially doing
> non-standard things - especially when debugging I happen to output stuff to
> the screen without going through printk and the like). Of course, this
> implies not using memset here. Jan
Then you should also update cls().

I have submitted the patch mostly for replacing memcpy by memmove.  Using 
memcpy for scrolling on ia64 makes garbage.

Feel free to improve the situation for creating blank lines!


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>