WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_sh

To: "James Morris" <jmorris@xxxxxxxxxx>
Subject: RE: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Thu, 13 Apr 2006 06:29:12 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 12 Apr 2006 15:29:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZeaUKdgSFuTDBCSkaoE5n3L5uWtQAFytOQ
Thread-topic: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().
>> Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>
>> 
>
>> +            if ( v->arch.shadow_vtable )
>> +                    unmap_domain_page_global(v->arch.shadow_vtable);
>> +                v->arch.shadow_vtable = NULL;
>
>Why not:
>
>               if ( v->arch.shadow_vtable ) 
>               {
>                       unmap_domain_page_global(v->arch.shadow_vtable);
>                       v->arch.shadow_vtable = NULL;
>               }
>

Yes, this is better :-),
thanks
-Xin

>
>-- 
>James Morris
><jmorris@xxxxxxxxxx>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>