This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [Xen-changelog] If the 'cdrom=' option is specified

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-changelog] If the 'cdrom=' option is specified in the definition file but media is
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Mon, 10 Apr 2006 20:29:30 +0100
Cc: Ross Maxfield <rmaxfiel@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 10 Apr 2006 12:29:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <443AA3F9.50609@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FT0P3-00015M-0U@xxxxxxxxxxxxxxxxxxxxx> <443AA3F9.50609@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Apr 10, 2006 at 01:29:13PM -0500, Anthony Liguori wrote:

> Xen patchbot -3.0-testing wrote:
> ># HG changeset patch
> ># User kaf24@xxxxxxxxxxxxxxxxxxxx
> ># Node ID fd526926e0d1c0671295aa7f4b952186c9345173
> ># Parent  408f51a850f47af4db20f43f281935909d502511
> >If the 'cdrom=' option is specified in the definition file but media is 
> >not found in the CD drive then main() in vl.c exits and the guest appears 
> >to hang.  This patch modifies vl.c slightly to check for the presents of 
> >media.  If the cdrom cannot be opened then the cd entry is removed from 
> >hd_filename[] and bs_table[] allowing the guest to continue initializing. 
> >If the guest requires the CD media then the guest should report, gracefully
> >or otherwise, that it's missing.
> >
> >From: Ross Maxfield <rmaxfiel@xxxxxxxxxx>
> >
> >Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
> >  
> Doesn't this need a Signed-off-by: Ross Maxfield <rmaxfiel@xxxxxxxxxx>?

People have been complaining that a patch should not retain the Signed-off-by
line if the patch has been modified, because they do not sign-off the modified
patch.  If a patch needs minor changes before it can be committed, we can
either bounce it back to the author, which seems unnecessarily heavyweight, or
do what Keir's done here, and sign-off the patch himself.  The From: line
retains the audit trail, credit, and copyright, and it's clear that Keir
himself thinks that this patch is acceptable.


Xen-devel mailing list