This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools/python pciif: fix some python format strin

To: Ryan <hap9@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/python pciif: fix some python format string operators
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Mon, 10 Apr 2006 14:52:48 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 10 Apr 2006 06:58:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1144676276.17916.13.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1144676276.17916.13.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Apr 10, 2006 at 09:37:56AM -0400, Ryan wrote:

> I used the wrong operator in a couple places for putting together some
> error messages out of format strings. This patch corrects those
> operators and fixes the strings.
> Signed-off-by: Ryan Wilson <hap9@xxxxxxxxxxxxxx>

Applied, thanks.

Could you provide your patches as an attachment in the future?  Your patch got
horribly mangled -- look how the plus signs wrap nicely onto the next line on
an 80-column display, in the hunk below.



@@ -131,7 +131,7 @@
                     nr_ports = size, allow_access = True)
             if rc<0:
                 raise VmError(('pci: failed to configure I/O ports on device '
-                            '%s - errno=%d')&(dev.name,rc))
+                            '%s - errno=%d')%(dev.name,rc))

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>