This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0/6] grantable and address conversion patches

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/6] grantable and address conversion patches
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 10 Apr 2006 18:34:17 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 10 Apr 2006 02:34:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <7cf280361d1f76b27804e5a27630314d@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060410083217.GC27482%yamahata@xxxxxxxxxxxxx> <7cf280361d1f76b27804e5a27630314d@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/

Thanks for your comments.

On Mon, Apr 10, 2006 at 09:54:20AM +0100, Keir Fraser wrote:

> 1/6: We can't apply this as it would change the public 3.0 interface 
> for x86/64. Do you really need a long? If so, we'll have to make that 
> field arch-dependent in some way.

Perhaps a long is not needed for several years at least.

> 2/6: This is a poor fix. Either we should make the ring size fixed 
> (e.g., 4kB) rather than architectural page-sized, or grants should be 
> dynamically allocated in netfront rather than statically allocated. 
> This was done quite some time ago for blkfront, and would be the 
> preferred (although more difficult) fix here.

I'll go this direction.

> 4/6: Make the function that fills in map/unmap requests arch-specific? 
> At least filling in host_addr should be arch-specific -- we don't 
> really want to overload dev_bus_addr like this.

O.K. I'll introduce virt_to_host_addr() to xenLinux and make a new patch.
Is there any explanaition about host_addr and dev_bus_addr?
When I wrote this patch,I guessed that host_addr should have been
arch-indepedent and dev_bus_addr could be arch-depedent.
But it was wrong. I couldn't find any good explaination/usage samples
of these field.


Xen-devel mailing list