This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] Fix __XEN_INTERFACE_VERSION__ old config bre

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Fix __XEN_INTERFACE_VERSION__ old config breakage
From: "Magnus Damm" <magnus.damm@xxxxxxxxx>
Date: Fri, 7 Apr 2006 18:10:41 +0900
Cc: Magnus Damm <magnus@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxx
Delivery-date: Fri, 07 Apr 2006 02:11:02 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bvlHBIlfb9xo33Z8w7QRLChbxYJjEqxKQDFtiWB8GwrqlUMf8++02fOzhN7E3E4IZBWBcLPx7ixPBo8mQnfkwZrCfkn6KOx4mJfoQBCblTozgeLRbmztktliAupOzwJaTm3XpT3yaO9/XUXcOH9cPeAYSw7pqqe4gGrG8sfm3MU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <3dbe81f0ccac9ae0aff4d67402ce4cd7@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060404224615.7472.23940.sendpatchset@xxxxxxxxxxxx> <3d8eece20604061733v235f1c1dpd9eac8f474d5b8b2@xxxxxxxxxxxxxx> <aec7e5c30604062117r42e574c1sb3470f86277932c1@xxxxxxxxxxxxxx> <e2545a07c6df5f2948181f6c4c03a91e@xxxxxxxxxxxx> <aec7e5c30604070048u6380dfet4dd052bc1b85ecf4@xxxxxxxxxxxxxx> <3dbe81f0ccac9ae0aff4d67402ce4cd7@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 4/7/06, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> On 7 Apr 2006, at 08:48, Magnus Damm wrote:
> >> Does this lead to a kernel that actually works (e.g., can you sgut it
> >> down without crashing)? I doubt it.
> >
> > I use a kernel config without CONFIG_XEN_INTERFACE_VERSION, and
> > building and running dom0 on x86 (in qemu) seems ok to me.
> I tried 'xm save' on such a domU and that doesn't work. The reason is
> that the kernel tree expects to be calling the new sched_op hypercall,
> but because the interface version gets defined to zero, it actually
> calls the old sched_op hypercall which takes different arguments. I
> also tried rebooting such a domU and that doesn't work (the guest is
> killed but not restarted) -- again because the old and new sched_op
> hypercall take their arguments in different ways.

Oh, I see. I did not test _that_ much. Good that you noticed.

> These problems are somewhat hidden I suppose, since you can boot and
> run happily with the domain for the most part, but it illustrates that
> if a guest is defining an obviously interface version we should fail
> the build, not build some inconsistent combination of guest kernel and
> hypervisor interface!

I'm afraid that I know too little about xen to say something about how
multiple interface versions are supposed to work, but I think your
plan of failing instead of building an inconsistent kernel sounds

My main concern was that the code didn't build with my old config
file, and the error message produced by the c-compiler was far from
user friendly. If the kernel build should fail then I would prefer
some see some kind of #error message.


/ magnus

Xen-devel mailing list