This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [RFC][PATCH] allow dom0 to power off machine using ACPI

To: Harry Butterworth <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] allow dom0 to power off machine using ACPI on shutdown.
From: Muli Ben-Yehuda <mulix@xxxxxxxxx>
Date: Thu, 06 Apr 2006 22:06:48 +0300
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 06 Apr 2006 12:07:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1144349930.21520.4.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1144348570.7725.9.camel@xxxxxxxxxxxxxxxxxxxxx> <20060406184602.GB20687@xxxxxxxxxxxxxxxxxxx> <1144349930.21520.4.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060126
On Thu, Apr 06, 2006 at 07:58:50PM +0100, Harry Butterworth wrote:

> The kernel is for both dom0 and domU.  I think in the domU case the
> hypervisor call is the correct mechanism to power off the virtual
> machine.

I meant in the dom0 case, of course.

> > > I thought this kind of solution was better than trying to import a lot
> > > more ACPI cruft into Xen.  Any thoughts?
> > 
> > I think you want kernel_power_off() here, which should do the right
> > thing for all architectures.
> No. kernel_power_off is currently already being called and doesn't work
> because it calls machine_power_off which in current unstable calls the
> hypervisor which doesn't power off the hardware.
> My patch modifies machine_power_off to call the native pm power off if
> present (i.e. if dom0) or the hypervisor if not (i.e. domU).

I see... Xen provides its own machine_power_off() in
drivers/xen/core/reboot.c. If we go with dom0 shutting the machine
down, the right fix would be to get rid of it and / or make it call
the arch specific machine_power_off().

Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Xen-devel mailing list