This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] - add symmetry to para and fully virtualized dom

To: Ben Thomas <bthomas@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] - add symmetry to para and fully virtualized domain shutdown/reboot
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 3 Apr 2006 19:18:13 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 03 Apr 2006 11:18:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44315805.2020502@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <443145FF.5050800@xxxxxxxxxxxxxxx> <673063b66257818262b5f3c8090319e0@xxxxxxxxxxxx> <44315805.2020502@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 3 Apr 2006, at 18:14, Ben Thomas wrote:

Ok, that's workable.  Is there anything else that needs modification ?

Do you foresee a need for any sort of need for filtering and/or
permissioning of allowable domains as specified in remote_shutdown ?
As long as a non-privileged domain may execute this op, what
level of protection(s) need to exist? (That also was part of my
factoring it into a DOM0 op).

I'm willing to go with anything that gets the job done. This is
one of several points of asymmetry that I'd like to see get

For now, IS_PRIV() is the correct check as for a dom0_op, but it can be revisited in future.

Apart from that the patch looked okay to me.

 -- Keir

Xen-devel mailing list