This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Patch to xm create search domU config in /etc/xen/auto

To: Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Patch to xm create search domU config in /etc/xen/auto
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Mon, 03 Apr 2006 11:39:11 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 03 Apr 2006 09:39:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <001901c65733$e270a6e0$0100000a@lualele>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <001901c65733$e270a6e0$0100000a@lualele>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mail/News 1.5 (X11/20060309)
Hope this doesn't appear to be singling you out, but this is a good opportunity to highlight some patch submitting good practices:

1) Your patch doesn't contain a Signed-off-by line so it cannot be applied.

2) Your patch is attached with an improper MIME type. If you cannot use a more sane mailer, you should also inline your patches (it's impossible for me to actually comment on your patch in a note without some nasty copy-paste stuff).

3) You include no explanation of why your patch is needed. It seems somewhat arbitrary to add /etc/xen/auto to the default search path. Why do you need this and why do you think other people would need this?

4) Your patch is based at a weird location (within tools/). It's usually best to patch at the top of the repository (diff -u a/tools/xen/xm/create.py b/tools/....). Actually, if you just use hg export, it'll do the right thing for you.

Please resubmit with the appropriate corrections.



Anthony Liguori

Itamar Reis Peixoto wrote:

Xen-devel mailing list

Xen-devel mailing list