This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] ia64 build fixes

On 2 Apr 2006, at 09:20, Keir Fraser wrote:

   Here's a patch that enables HYPERVISOR_sched_op() and
HYPERVISOR_sched_opt_compat() for ia64.  We currently have no users of
this call, but there's no harm in enabling it (tested by adding a
HYPERVISOR_yield() call to default_idle()). I did notice a problem with
the compat interface though, nothing defines __XEN_INTERFACE_VERSION__
for the build of xen.  We're therefore stuck on interface version
0x00000000 where __HYPERVISOR_sched_op_compat == __HYPERVISOR_sched_op.

Well, it doesn't actually matter right now since Xen itself does not use the __HYPERVISOR_foo numbers. But yes, I can see this might bite us later so we ought to define it.

Ah, I'm forgetting you have a hypercall switch statement. I'll add the version number.

With regard to your patch, actually I was thinking more about the vmx hypercall interface which already supports sched_op_compat --- should that one have sched_op added too, in vmx_hypercall.c?

 -- Keir

Xen-devel mailing list