This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] - Makefiles for tools/loader/{hvmloader|vmxassis

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] - Makefiles for tools/loader/{hvmloader|vmxassist}
From: "Ben Thomas" <bthomas@xxxxxxxxxxxxxxx>
Date: Sat, 1 Apr 2006 06:12:41 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 01 Apr 2006 11:12:13 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <442D9E11.1040406@xxxxxxxxxxxxxxx> <7563f501577984d02e328dabf3e3cb41@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZVa8dTGxYPQRAqTjmr0f0R3AgXJQAEGix+
Thread-topic: [Xen-devel] [PATCH] - Makefiles for tools/loader/{hvmloader|vmxassist}

-----Original Message-----
From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
Sent: Sat 4/1/2006 4:03 AM
To: Ben Thomas
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] - Makefiles for tools/loader/{hvmloader|vmxassist}

On 31 Mar 2006, at 22:24, Ben Thomas wrote:

> In FC5, gcc has issues with the command lines used to build
> hvmloader and vmxassist.  Basically, the compiler doesn't
> like the combination of -m64 and -m32.  As these are 32 bit
> apps, and intended to be, take a modified approach and simply
> define XEN_TARGET_ARCH for 32 bits.  This cleans up the
> command line and builds the images correctly.
> We could also wait for a gcc fix, but...

No, this patch is sane. Putting both switches on the command line makes
no sense. I wonder whether to simply put 'CFLAGS :=' *after* the
include of Rules.mk though.

  -- Keir

Possibly.  I have a feeling that CFLAGS wasn't the only thing.  Perhaps LDFLAGS got modified as well ?  I cannot recall.  The image really needs to be 32 bits, as near as I can see.

I tried a few options, but eventually tired of trying to outguess make and gcc.  In the end, this is a 32 bit app and this patch worked.  However, you're more familiar with the environment than I am. As long as it builds/works, I'm happy.  I actually waited a few days to see if someone else would fix it before I did.


Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>