WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] enable modifying of registers from gdb


On 29 Mar 2006, at 03:56, Kamble, Nitin A wrote:

I have updated the code with more fixes/changes in the patch and also cleaned up the map_domain_va code further. Now gdb is able to get guest memory correctly in various guest modes.

Nitin,

Most of the patch looks fine, except for your changes to setvcpucontext in domain.c.

I think you should get rid of hvm_modify_guest_state() entirely (deleting both svm and vmx implementations) and replace the call to it in arch_set_info_guest() with a call to hvm_load_cpu_guest_regs().

I would then expect that your patch in domain.c is unnecessary: it should work for you to call arch_set_info_guest() regardless of whether DOMF_debugging is set.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel