WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [RFC PATCH 31/35] Add Xen grant table support

To: "Arjan van de Ven" <arjan@xxxxxxxxxxxxx>, "Chris Wright" <chrisw@xxxxxxxxxxxx>
Subject: [Xen-devel] RE: [RFC PATCH 31/35] Add Xen grant table support
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Wed, 22 Mar 2006 10:25:42 -0800
Cc: virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>
Delivery-date: Wed, 22 Mar 2006 18:27:02 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZNjeOyN+awk9XAS5mvABbfh6SptAAT3Sfw
Thread-topic: [RFC PATCH 31/35] Add Xen grant table support
> > +#ifndef __ia64__
> > +static int map_pte_fn(pte_t *pte, struct page *pte_page,
> > +                 unsigned long addr, void *data)
> > +{
> > +   unsigned long **frames = (unsigned long **)data;
> > +
> > +   set_pte_at(&init_mm, addr, pte, pfn_pte((*frames)[0], 
> PAGE_KERNEL));
> > +   (*frames)++;
> > +   return 0;
> > +}
> 
> looks to me the wrong ifdef for a file in arch/i386... please fix

FYI, the grant table support is also used by non-x86 Xen architectures
(currently ia64 and soon ppc) so grant table files (along with event
channel files and some others) will eventually need to move out
of mach-xen.  The files are currently in drivers/xen/core in the Xen
tree, which is not really a good place either.  Suggestions?

Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] RE: [RFC PATCH 31/35] Add Xen grant table support, Magenheimer, Dan (HP Labs Fort Collins) <=