xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] minor Makefile fix

from [Aron Griffis]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] minor Makefile fix
From:	Aron Griffis <aron@xxxxxx>
Date:	Tue, 21 Mar 2006 16:51:56 -0500
Delivery-date:	Tue, 21 Mar 2006 21:53:18 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.11

The patch below prevents a stray error message in the case that either
DISTDIR or DESTDIR is empty, by preventing readlink from being called
in that case.

Another option would be to use readlink -s, but that has the
undesirable effect of staying silent in situations other than empty
DISTDIR/DESTDIR

Signed-off-by: Aron Griffis <aron@xxxxxx>

diff -r 9afd25b90af4 tools/examples/Makefile
--- a/tools/examples/Makefile   Mon Mar 20 09:56:58 2006 -0700
+++ b/tools/examples/Makefile   Tue Mar 21 16:53:04 2006 -0500
@@ -38,8 +38,8 @@ UDEV_RULES_DIR = /etc/udev
 UDEV_RULES_DIR = /etc/udev
 UDEV_RULES = xen-backend.rules

-DI = $(shell readlink -f $(DISTDIR))
-DE = $(shell readlink -f $(DESTDIR))
+DI = $(if $(DISTDIR),$(shell readlink -f $(DISTDIR)),)
+DE = $(if $(DESTDIR),$(shell readlink -f $(DESTDIR)),)
 ifeq ($(findstring $(DI),$(DE)),$(DI))
 HOTPLUGS=install-hotplug install-udev
 else

pgpmWN2MwKxYB.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] minor Makefile fix, Aron Griffis <=

Previous by Date:	RE: [Xen-devel] Bugs in mini-os on i386 architecture, Puthiyaparambil, Aravindh
Next by Date:	[Xen-devel] [PATCH][SVM] fix issue with svm inst decode, Woller, Thomas
Previous by Thread:	[Xen-devel] [PATCH] xen_sysfs.c build fix, Alex Williamson
Next by Thread:	[Xen-devel] [PATCH][SVM] fix issue with svm inst decode, Woller, Thomas
Indexes:	[Date] [Thread] [Top] [All Lists]