WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] Fix the implicit declaration of function

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Xen-changelog] Fix the implicit declaration of function `swiotlb_init' warning, by including
From: Muli Ben-Yehuda <mulix@xxxxxxxxx>
Date: Tue, 21 Mar 2006 22:49:46 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Mar 2006 20:51:30 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20060321195357.GA6930@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FLggh-0002qh-Qj@xxxxxxxxxxxxxxxxxxxxx> <20060321184601.GC6126@xxxxxxxxxxxxxxxxxxx> <20060321195357.GA6930@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060126
On Tue, Mar 21, 2006 at 07:53:57PM +0000, Ewan Mellor wrote:
> 
> Why, dare I ask?

There are two conventions here: no #ifdefs in C files if possible, and
#include <linux/xxx> comes before #include <asm/xxx>. The first one
helps readability and maintainability, the second one helps
readability and stems from letting arch specific include files
overrride generic include files.

But really, it's just the accepted kernel idiom, and if we want
upstream inclusion, it pays to play by the rules.

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>