Re: [Xen-devel] [PATCH] clean up CFLAGS

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 9 Mar 2006, at 19:42, Charles Coffing wrote:

> I've put some default CFLAGS (-Wall -O3) in Config.mk, and removed
> redundant flags from the Makefiles.  I've also fixed a few places that
> didn't properly inherit CFLAGS from Config.mk (but not vmxassist or
> hvmloader; those ignore global defaults like before).  Also, individual
> makefiles still add their own custom flags (-g, -Werror, -f*, etc) just
> as before.
>
> Please apply to xen-unstable.
I'll take a look at applying some of these piecemeal. After a quick 
browse I see that the miniterm Makefile is broken (it is intended to be 
built and installed on the external box, not the Xen box, so HOSTCC is 
probably right for it but the potentially cross-compiling CC is 
definitely not), and the changes to vmxassist and hvmloader have no 
effect and I see no reason to prefer them over what is there already. 
No comment on the rest as yet...
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel