WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][discuss] io_apic disable_8254_timer

To: "Woller, Thomas" <thomas.woller@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH][discuss] io_apic disable_8254_timer
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 3 Mar 2006 13:12:45 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 03 Mar 2006 13:13:04 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F35BBA9A7A4D684FBFCEA191F108E53911CD2322@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F35BBA9A7A4D684FBFCEA191F108E53911CD2322@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 2 Mar 2006, at 21:29, Woller, Thomas wrote:

This patch only adds "disable_8254_timer" and leaves the default as
enabled - ie. There is no "enable_8254_timer" in this patch.  The linux
solution provides more detailed determination of whether to
enable/disable using timer_over_8254, including determining if ATI
chipset is present. Most of which is most likely not necessary with xen
hv at this time.

The added code in this patch could be ifdef 64bit, as the linux solution
is only implemented in the x86_64 io_apic.c code.
Tom

Actually this gives me an excuse to pick a scab and get rid of the 'missed tick' logic that relies on that code altogether. So I just deleted the line instead of making it conditional. I'm pretty sure that won't break anything.

 Thanks,
 Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>