This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Allow building with perfc and perfc_arrays

To: Chris Wright <chrisw@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Allow building with perfc and perfc_arrays
From: Ben Thomas <bthomas@xxxxxxxxxxxxxxx>
Date: Thu, 16 Feb 2006 17:17:47 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 16 Feb 2006 22:30:16 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20060216212643.GS3490@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43F4D80C.4050308@xxxxxxxxxxxxxxx> <20060216212643.GS3490@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)

Well, I did use the phrase "simple-minded".  It seemed like
adequate warning.  ;-)

My goal was to get it compiling and out of my way so that
I could work on something else.  This was purely annoying and
I spent very little time on it.  Then, once I got it compiling,
the guilt-gene kicked in and I thought I should submit the

Your changes are more complete, and I like them better.

(Now, if I could manage to spend the time to package up other
 changes that I've made ...)


Chris Wright wrote:
* Ben Thomas (bthomas@xxxxxxxxxxxxxxx) wrote:

Attempts to build with either perfc or perfc_arrays fails.  Some of
this is specific to the platform (eg, __x86_64__).  Add simple-minded
fixes to allow building with these options.

This patch resolves these issues and now builds on i386 and x86_64

I was just doing similar.  Only real difference I had was just using
char in the dom0_perfc_desc instead of the char* cast.

 typedef struct dom0_perfc_desc {
-    uint8_t      name[80];             /* name of perf counter */
+    char         name[80];             /* name of perf counter */

And a typo fix, which you accidentally propagate.

+PERFCOUNTER_CPU(apshot_pages,            "apshot_pages")

I had simply done:

-        perfc_decr(apshot_pages);
+        perfc_decr(snapshot_pages);

Accidental conversion to percpu counter of a couple of these.  And,
finally, this isn't quite enough for PAE.

Here's my patch, mind taking a double check?


Xen-devel mailing list