WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] X86_64 "assert" when booting 64-bit image.

To: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
Subject: Re: [Xen-devel] X86_64 "assert" when booting 64-bit image.
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 9 Feb 2006 17:06:11 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 09 Feb 2006 17:11:45 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <907625E08839C4409CE5768403633E0B0EABE2@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <907625E08839C4409CE5768403633E0B0EABE2@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 9 Feb 2006, at 16:52, Petersson, Mats wrote:

I think that the correct thing to do is to remove that whole
middle portion of __shadow_status(). That is, the entire
outermost 'if'
statement. (That is, the 'if ( VALID_MFN()....' all the way
to 'return 0; }').

Can you please try that out and see how it works for you?

I've done that [I did it first using a #if 0, but I've now hit the
"delete" key for it...] - Patch attached.

I don't know if I need to add this for removing existing lines of code:
Signed off by: Mats Petersson  mats.petersson@xxxxxxx

No, please try removing the if statement *as well*. That whole conditional return of 0 should go away -- the only return statement in that function should be the one on the final final of the function. Let me know how that works out.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel