This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] [Xen-devel] [PATCH]Make VTIdomain boot again

To: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [Xen-devel] [PATCH]Make VTIdomain boot again
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 08 Feb 2006 20:32:23 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 09 Feb 2006 03:43:49 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <2BF508F394C196468CCBEC031320DCDF3808CE@pdsmsx405>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <2BF508F394C196468CCBEC031320DCDF3808CE@pdsmsx405>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-02-09 at 10:31 +0800, Xu, Anthony wrote:
> Keir,
> This patch is intended to make VTIdomain boot again, and will not impact
> domU. Actually VTIdomain and domU can boot simultaneously after applying
> this patch, Could you please check this patch into xen-unstable.hg? This
> is a must in 3.0.1.

Hi Anthony,

   Xen 3.0.1 went out on Feb. 1st.  A couple comments

--- a/xen/arch/ia64/linux-xen/irq_ia64.c        Thu Jan 26 10:31:28 2006
+++ b/xen/arch/ia64/linux-xen/irq_ia64.c        Wed Feb  8 16:28:11 2006
@@ -169,7 +169,7 @@
         * handler needs to be able to wait for further keyboard
interrupts, which can't
         * come through until ia64_eoi() has been done.
-       irq_exit();
+       xen_irq_exit(regs);

>>> This needs to be in an #ifdef XEN.

-void irq_exit(void)
+void xen_irq_exit(struct pt_regs *regs)
-       if (!in_interrupt() && local_softirq_pending()) {
+    if((((char *)regs) -(char *) current) !=
+        return;
+       if (!in_interrupt()&&local_softirq_pending()) {

>>> Formatting here is inconsistent with the rest of the file and
itself.  Could we be setting some flag and adding the test to the
existing in_interrupt/local_softirq_pending check?  This looks rather
precarious.  Thanks,


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>