WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] changeset 8775

To: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] changeset 8775
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 8 Feb 2006 10:15:22 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 08 Feb 2006 10:27:26 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43E9C9CC.76F0.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43E9C9CC.76F0.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 8 Feb 2006, at 09:37, Jan Beulich wrote:

Also, some of other code seems then superfluous or even ill:
- drivers/xen/core/smpboot.c: smp_prepare_cpus() should not initialize cpu_possible_map again, but should instead have its main loop controlled by this bit vector (and VCPUOP_is_up doesn't need to be called then anymore, too)

I now fixed smp_prepare_boot_cpu/smp_prepare_cpus to respect the cpu_possible_map.

- arch/{i386,x86_64}/kernel/mpparse-xen.c: the setting of num_processors was and is completely out of sync with the real set of VCPUs used; I even wonder what purpose the whole file still serves

Yes, we would like to get rid of at least the CPU/local-APIC portions of mpparse.c. If there's no IRQ/IO_APIC info in those tables we can get rid of the whole file.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>