This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xense-devel] [PATCH] dom0_ops -EPERM not -EACCES?

To: xense-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xense-devel] [PATCH] dom0_ops -EPERM not -EACCES?
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Thu, 24 Nov 2005 12:35:42 +1100
Cc: Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 07 Feb 2006 09:09:58 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xense-devel-request@lists.xensource.com?subject=help>
List-id: "A discussion list for those developing security enhancements for Xen." <xense-devel.lists.xensource.com>
List-post: <mailto:xense-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xense-devel>, <mailto:xense-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xense-devel>, <mailto:xense-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xense-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi all,

        dom0_ops return -EACCES when the interface version in wrong.  I think
that an acm failure is closer to being non-priv'ed, which returns
-EPERM.  Wouldn't want dom0 tools to report they were the wrong version
just because ACM limited some operation, surely?

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (authored)

diff -r e2d1c88d50f7 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c     Thu Nov 24 00:55:37 2005
+++ b/xen/common/dom0_ops.c     Thu Nov 24 12:31:37 2005
@@ -102,7 +102,7 @@
         return -EACCES;
     if ( acm_pre_dom0_op(op, &ssid) )
-        return -EACCES;
+        return -EPERM;

A bad analogy is like a leaky screwdriver -- Richard Braakman

Xense-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xense-devel] [PATCH] dom0_ops -EPERM not -EACCES?, Rusty Russell <=