This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI Backend/Frontend

To: "Ryan" <hap9@xxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI Backend/Frontend
From: "Dave Thompson \(davetho\)" <davetho@xxxxxxxxx>
Date: Mon, 6 Feb 2006 13:45:16 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 06 Feb 2006 18:56:08 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYloKu5cfTyKfCuRvmqjbmV/w4iFQFrC35g
Thread-topic: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI Backend/Frontend

I found a bug in this patch.  The function pciback_publish_pci_roots()
added in the file linux-2.6-xen-sparse/drivers/xen/pciback/passthrough.c
sets the local variables domain and bus using the dev_entry pointer
which is uninitialized at this point.  The two lines which set these
variables should be moved down so that they are within the
list_for_each_entry loop.

Dave Thompson

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Ryan
> Sent: Monday, January 30, 2006 7:24 AM
> To: xen-devel
> Subject: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI 
> Backend/Frontend
> This patch contains the PCI backend and frontend drivers for Linux
> 2.6.12. There are a couple of compile-time options in the backend and
> frontend although the defaults should be sufficient to get you up and
> running.

Xen-devel mailing list