This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI Backend/Frontend

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI Backend/Frontend
From: Ryan <hap9@xxxxxxxxxxxxxx>
Date: Mon, 30 Jan 2006 13:43:38 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 30 Jan 2006 18:53:16 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43DE2B6E.1040504@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1138627454.8080.9.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <43DE2B6E.1040504@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2006-01-30 at 09:06 -0600, Anthony Liguori wrote:
> Hi Ryan,
> It would be nice if you could run your patches through lindent and 
> resubmit.  You do a couple things that don't follow kernel style 
> guidelines (lack of spaces around operators and else clauses on 
> newlines).  Strictly adhering to the CodingStyle now will make upstream 
> merge significantly easier in the future.
> Thanks,
> Anthony Liguori

Is the attached file better formatted? I used lindent. I also added a
couple of macros to simplify readability and reduce code size (lindent
changed some formatting that brought some code duplication to my

Attachment: pci-ddi.patch
Description: Text Data

Xen-devel mailing list