This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


do_* declarations (was: Re: [Xen-ia64-devel] [PATCH] added multicall)

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: do_* declarations (was: Re: [Xen-ia64-devel] [PATCH] added multicall)
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Thu, 26 Jan 2006 11:10:30 +0100
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 26 Jan 2006 09:15:45 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200601260433.AA02168@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200601251455.19500.Tristan.Gingold@xxxxxxxx> <200601260433.AA02168@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5

on ia64, the do_* functions for hypercalls are called in C.  However, they are 
not declared in any .h file.  I think it is cleaner to declare them in an 
header file rather than locally.  The question is in which header file.
Thank you for any suggestion.

The do_* functions are at least:
extern long do_ni_hypercall(void);
extern long do_dom0_op(dom0_op_t *u_dom0_op);
extern long do_memory_op(int cmd, void *arg);
extern long do_multicall(multicall_entry_t *call_list, unsigned int nr_calls);
extern long do_event_channel_op(evtchn_op_t *uop);
extern long do_xen_version(int cmd, void *arg);
extern long do_console_io(int cmd, int count, char *buffer);
extern long do_grant_table_op(unsigned int cmd, void *uop, unsigned int 


Le Jeudi 26 Janvier 2006 05:33, Masaki Kanno a écrit :
> Hi, Tristan
> Thank you for advice. Please give me advice once again.
> I was not able to find an appropriate common header. In which header
> do you define them in case of you?
>  - xen/hypercall.h (new)
>  - xen/multicall.h
>  - asm/multicall.h
>  - etc
> I think xen/hypercall.h is better.
Why not.  I send this mail to xen-devel, so that we can have official advices!

> Best regards,
>  Kan
> Tristan Gingold wrote:
> >Le Mercredi 25 Janvier 2006 13:09, Masaki Kanno a 馗rit :
> >> Hi,
> >>
> >> This patch added multicall hypercall.
> >> The xm top command succeeded.
> >>
> >> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
> >>
> >> Best regards,
> >>  Kan
> >
> >Hi,
> >
> >I personnaly think that these declarations
> >+extern long do_ni_hypercall(void);
> >+extern long do_dom0_op(dom0_op_t *u_dom0_op);
> >+extern long do_memory_op(int cmd, void *arg);
> >+extern long do_multicall(multicall_entry_t *call_list, unsigned int
> >nr_calls);
> >+extern long do_event_channel_op(evtchn_op_t *uop);
> >+extern long do_xen_version(int cmd, void *arg);
> >+extern long do_console_io(int cmd, int count, char *buffer);
> >+extern long do_grant_table_op(unsigned int cmd, void *uop, unsigned int
> >count);
> >
> >should go in common headers.  They will be checked with definitions and
> > this will avoid to re-declare them in some other files.
> >
> >Tristan.

Xen-ia64-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>