This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fixing bug/typo in main.py

To: Yoshinori Katase <y_katase@xxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fixing bug/typo in main.py
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Thu, 12 Jan 2006 12:26:55 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 12 Jan 2006 12:33:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20060111072028.395851C004@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060111072028.395851C004@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Jan 11, 2006 at 04:21:21PM +0900, Yoshinori Katase wrote:

> This patch fixes a typo of main.py.
> 1.xm reboot help is shown only 3 arguments.

What you've done here isn't right.  xm reboot is redirected through xm
shutdown, but that's just a messy implementation detail.  xm shutdown -H means
shutdown and don't restart regardless of configuration to the contrary -- xm
reboot -H therefore does not make any sense.  xm shutdown -R is exactly the
same as xm reboot, and so xm reboot -R does not make any sense either.

We ought to change the arg_check for xm_reboot to allow a maximum of 3
arguments, but better would be to rewrite shutdown.py so that the handling of
the call to the server was separate from the argument handling and this mess
was sorted out properly.  Any volunteers?



Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>