WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [RFC] sysfs support for xen linux

To: xen-devel@xxxxxxxxxxxxxxxxxxx, "Mike D. Day" <ncmike@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [RFC] sysfs support for xen linux
From: Gawain Lynch <gawain.lynch@xxxxxxxxxxx>
Date: Wed, 11 Jan 2006 02:23:20 +1300
Delivery-date: Tue, 10 Jan 2006 13:29:48 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43C2F324.4020407@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43C2F324.4020407@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> diff -r c08884b412da -r cec2fc0a07c6 
> linux-2.6-xen-sparse/arch/xen/kernel/xen_sysfs.c
> --- /dev/null Mon Jan  9 21:55:13 2006
> +++ b/linux-2.6-xen-sparse/arch/xen/kernel/xen_sysfs.c        Mon Jan  9 
> 23:07:04 2006

<SNIP>

> +#ifndef BOOL
> +#define BOOL    int
> +#endif
> +
> +#ifndef FALSE
> +#define FALSE   0
> +#endif
> + 
> +#ifndef TRUE
> +#define TRUE    1
> +#endif
> + 
> +#ifndef NULL
> +#define NULL    0
> +#endif

These are already defined in kernel and a favourite nit pick on LKML.


> +struct xen_sysfs_attr
> +{
struct xen_sysfs_attr {

New line for braces are reserved for functions()

> +struct xen_sysfs_object 
> +{
struct xen_sysfs_object {

> --- /dev/null Mon Jan  9 21:55:13 2006
> +++ b/linux-2.6-xen-sparse/include/asm-xen/xen_sysfs.h        Mon Jan  9 
> 23:07:04 2006

<SNIP>

> +#ifndef BOOL
> +#define BOOL    int
> +#endif
> +
> +#ifndef FALSE
> +#define FALSE   0
> +#endif
> + 
> +#ifndef TRUE
> +#define TRUE    1
> +#endif
> + 
> +#ifndef NULL
> +#define NULL    0
> +#endif
> 

See above...




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel