WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH][RESEND] add "acpi" option in xmexample.vmxconfig

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][RESEND] add "acpi" option in xmexample.vmxconfig file
From: "Yu, Ke" <ke.yu@xxxxxxxxx>
Date: Sat, 31 Dec 2005 00:15:24 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 30 Dec 2005 16:20:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYNK+VYzZV0OFr+Sg2ke6/tsXIPIQAL//Eg
Thread-topic: [Xen-devel] [PATCH][RESEND] add "acpi" option in xmexample.vmxconfig file
Thanks for the good suggestion. Will send the updated patch later. 

>-----Original Message-----
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
>Sent: 2005年12月30日 18:33
>To: Yu, Ke
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] [PATCH][RESEND] add "acpi" option in 
>xmexample.vmxconfig file
>
>
>On 30 Dec 2005, at 01:52, Yu, Ke wrote:
>
>> Rebase the patch due to its conflict with new changeset 8445.
>> Would somebody apply it or give some comments? Thanks
>
>The info block written by vmx builder is no longer merely vcpu 
>information. Hence its name and the magic string at the start of the 
>block are badly named.
>
>I would like to see a more ACPI-styled table. At the moment, can you 
>please define a struct something like the following (where the 
>definition is available both to vmx builder and vmxassist -- I guess 
>the struct may need to be copied in two different header files):
>
>struct hvm_info_table {
>     char signature[8]; /* "HVM INFO" */
>     u32 length;
>     u8 checksum;
>     u8 acpi_enabled;
>     u8 pad[2];
>     u32 nr_vcpus;
>};
>
>Where the checksum is a simple ACPI-style twos-complement byte 
>summation and test for zero.
>
>This has the advantages of a meaningful name and gets rid of magic 
>numbers (indexes into array of unsigned ints).
>
>  -- Keir
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel