WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] pfn_pte/pfn_pmd

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] pfn_pte/pfn_pmd
From: Gerd Knorr <kraxel@xxxxxxx>
Date: Wed, 21 Dec 2005 15:25:56 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 21 Dec 2005 14:28:52 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43A94AE7.76F0.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43A9401F.76F0.0078.0@xxxxxxxxxx> <43A94AE7.76F0.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.6 (X11/20050715)
I still wonder, however, whether the BUG()/panic() in PAE's pfn_pmd()
couldn't be removed...

Wonder why it is still in there though, seems pfn_pmd() is never ever used, checking code ...

Ok, seems they are needed for 2M/4M pages, we don't support these anyway, so BUG()'ing in case this is called looks perfectly fine.

The panic msg probably should be changed to something more reasonable, such as "Huh? Who tried to use 2M pages?" maybe ;)

cheers,

  Gerd


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>