WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] check before relinquishing vlapic because VMX domain

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] check before relinquishing vlapic because VMX domain may crash very early
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Thu, 15 Dec 2005 16:24:26 +0800
Delivery-date: Thu, 15 Dec 2005 08:26:23 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYBUPXi4/4fqd+4Ta6DzssOjfuI2Q==
Thread-topic: [PATCH] check before relinquishing vlapic because VMX domain may crash very early
check before relinquishing vlapic because VMX domain may crash very
early.

Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>

Also pls push to xen-3.0-testing.hg.

thanks

diff -r dc8122d90670 xen/arch/x86/vmx.c
--- a/xen/arch/x86/vmx.c    Wed Dec 14 18:47:16 2005
+++ b/xen/arch/x86/vmx.c    Thu Dec 15 16:18:14 2005
@@ -113,9 +113,10 @@
     if ( active_ac_timer(&v->arch.arch_vmx.hlt_timer) ) {
         rem_ac_timer(&v->arch.arch_vmx.hlt_timer);
     }
-    if ( vmx_apic_support(v->domain) ) {
-        rem_ac_timer( &(VLAPIC(v)->vlapic_timer) );
-        xfree( VLAPIC(v) );
+    if ( vmx_apic_support(v->domain) && (VLAPIC(v) != NULL) ) {
+        if ( active_ac_timer(&(VLAPIC(v)->vlapic_timer)) )
+            rem_ac_timer(&(VLAPIC(v)->vlapic_timer));
+        xfree(VLAPIC(v));
     }
 }

Attachment: fix_exit.patch
Description: fix_exit.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] check before relinquishing vlapic because VMX domain may crash very early, Li, Xin B <=