WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Remove uneeded 'else if' when closing event chan

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Remove uneeded 'else if' when closing event channels.
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Sat, 03 Dec 2005 10:31:00 +1100
Cc: Xen-Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 02 Dec 2005 23:30:56 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6db9374a4edb3d812498d5c59d169e17@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20051202050519.GB25348@xxxxxxxxxxxxxxxxxx> <6db9374a4edb3d812498d5c59d169e17@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2005-12-02 at 10:17 +0000, Keir Fraser wrote:
> On 2 Dec 2005, at 05:05, Tony Breeds wrote:
> 
> > Hi all,
> >     As far as I can see the remote domain cannot change from
> > underneath us.  Which means that the test for that situation is
> > pointless
> >
> > This patch removes it.
> >
> > Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
> 
> It can change, between lines 340 and 341 (where we have no locks held).

Hmm, you mean same domain makes another hypercall in parallel to close
the event channel then rebind it to a different domain?

In which case, close fails with EINVAL?

Confused,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel