WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] remove use of get_gendisk in blkfront

To: "Jeremy Katz" <katzj@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] remove use of get_gendisk in blkfront
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Wed, 9 Nov 2005 10:48:01 -0000
Cc: Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>
Delivery-date: Wed, 09 Nov 2005 10:48:15 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcXk4VoMayAlQf4jTmCHPXsUUKBKgwANx0RQ
Thread-topic: [Xen-devel] [PATCH] remove use of get_gendisk in blkfront
> On Fri, 2005-09-02 at 16:28 +0800, Xiaofeng Ling wrote:
> > remove use of get_gendisk in blkfront
> > gen_gendisk is no long exported by 2.6 kernel. this patch 
> remove the 
> > call of get_gendisk by saving the gd point in blkfront_info 
> in vbd.c 
> > so that blkfront can be built as kerenl module.
> > 
> > Signed-off-by: Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>
> 
> This looks correct to me and helps in building blkfront as a module.
> Any chance of getting it committed?  I've gone ahead and 
> rediffed against the current tip and cleaned up the warnings. 
>  Attached here.

Looks good to me -- AFAIK it was only dropped by accident first time
around.

Folks: if you submit a patch for inclusion please keep resending every
48h until you get some kind of response or it's committed.

[Aside: it would be really nice if there was some tool that pulled
patches off a mailing list and fed them into something like bugzilla,
along with all the coments associated with a patch. It should also watch
the changelog list and update the status as 'APPLIED' when appropriate.
At any time an author could withdraw/supercede a patch, and a maintainer
could reject/keep-on-file. A really smart system would also keep patches
fresh by trying to rebase them, or at least note if they still apply
cleanly.]

Thanks,
Ian 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel