Re: [Xen-devel] Re: new gnttab_end_foreign_access?

[Christopher Clark <christopher.clark@xxxxxxxxxxxx>]

The readonly arg isn't used but was originally intended to allow you to
drop a grant from allowing readwrite access to just readonly.

Haven't had a look at the new interface changes yet.

Christopher

On 11/3/05, NAHieu <nahieu@xxxxxxxxx> wrote:

On 11/3/05, NAHieu <nahieu@xxxxxxxxx> wrote:
> I have one more question:why gnttab_end_foreign_access_ref(grant_ref_t
> ref, int readonly) needs the "readonly" arg?
>
> Is gnttab_end_foreign_access_ref(grant_ref_t ref) not OK?
>


I took another look, and it seems we should remove "readonly" arg of
gnttab_end_foreign_access*, as they are not in use.

So those  API should be:

int gnttab_end_foreign_access_ref(grant_ref_t ref);
void gnttab_end_foreign_access(grant_ref_t ref, unsigned long page);


I still have some doubt about the "page" arg, however.

Thanks
Hieu

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel