WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenoprof for SMP domains: patch for linux-sparse

To: "Santos, Jose Renato G" <joserenato.santos@xxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenoprof for SMP domains: patch for linux-sparse tree
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 20 Oct 2005 12:18:56 +0100
Cc: Yoshio Turner <yoshiotu@xxxxxxxxxx>, Andrew Theurer <habanero@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, G John Janakiraman <john@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 20 Oct 2005 11:20:37 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6C21311CEE34E049B74CC0EF339464B924B4BE@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <6C21311CEE34E049B74CC0EF339464B924B4BE@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 19 Oct 2005, at 19:45, Santos, Jose Renato G wrote:

  Attached is another patch for xenoprof

  3) xenoprof-2.0-linux-2.6-sparse.patch:
     Contains oprofile architecture specific driver for Xen (to be used
against linux sparse tree)

A few comments on this one:
1. No need to define virq_to_phys(). bind_virq_to_irq() returns the irq number, so just store it somewhere convenient rather than defining a query function. 2. I just checked in a more flexible alternative to vm_map_xen_pages which may be useful in other situations in future. Please switch to using direct_kernel_remap_pfn_range(). 3. Please use Linux indentation style throughout. I see in some places someone used 2-space soft tabs for example. 4. Make profiling config options (oprofile/Kconfig) 'default n', and do not add to default -xen0/-xenU configurations. You can add as a module to the -xen configurations if you like.

I only pick on this patch because it's the first one I looked at. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>