WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Switching from writeable pagetable to shadowlog-dirtyat

To: "Li, Chengyuan" <chengyuan.li@xxxxxxxxx>
Subject: Re: [Xen-devel] Switching from writeable pagetable to shadowlog-dirtyat runtime
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 14 Oct 2005 09:43:31 +0100
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Delivery-date: Fri, 14 Oct 2005 08:42:47 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <59D45D057E9702469E5775CBB56411F19C4C32@pdsmsx406>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <59D45D057E9702469E5775CBB56411F19C4C32@pdsmsx406>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 14 Oct 2005, at 03:46, Li, Chengyuan wrote:


I don't see ptwr_flush() when shadow mode enable in both ia32 and x86_64 code. Why plain ia32 log dirty shadow can work?

Perhaps it can't, properly. :-)

The best fix will be to make domain_pause() call sync_pagetable_state(d). The main problem I can see is that the cleanup_writeable_pagetable() function is not currently safe to be called by other than the subject domain. For example, failure paths crash the calling domain rather than the subject domain! This needs fixing.

audit_adjust_pgtables() is for plain ia32 only and it doesn't work for both ia32 pae and x86_64, but this function only check the ref counts and doesn't update guest PTE entry, e.g. R/W bit.

Another question is that how does guest update its guest page-table after shadow mode is enabled? As writable-pagetable can't be used after shadow mode is enabled.

Shadow pagetable code has its own quite separate writeable pagetable logic, I believe. Which is why the non-shadow wrpt state must be flushed before switching to shadow pagetables.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>