WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][VT] Patch to allow VMX domainsto be destroyedor

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][VT] Patch to allow VMX domainsto be destroyedor shut down cleanly
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 19 Sep 2005 10:17:12 +0100
Cc: Khoa Huynh <khoa@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 19 Sep 2005 09:10:21 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <FFEFE1749526634699CD3AC2EDB7627A454381@pdsmsx406>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <FFEFE1749526634699CD3AC2EDB7627A454381@pdsmsx406>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 19 Sep 2005, at 06:54, Jiang, Yunhong wrote:

More exactly should be:
        if (!vmx_paging_enabled(d)) {
                        get_page for new mfn
                        put_page for old mfn
        }

What would old_mfn be in this case?

If we do any cr3 ref-counting on cr0 writes I would expect it to be:
 * put_page() on clearing of CR0_PG
 * get_page() on setting of CR0_PG

Given that writing cr3 currently does a get_page/put_page regardless of the setting of CR0_PG, is there any need to be doing get_page() within vmx_set_cr0()?

I think it's more correct to do get/put in vmx_set_cr0 (at that point we can know what format the pagetables should be, for example (32/32p/64). But I think it's a bigger cleanup patch.

Whatever you go for: please send a complete tested patch. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel