WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Broken timer macros breaks VMX

To: Leendert van Doorn <leendert@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Broken timer macros breaks VMX
From: Arun Sharma <arun.sharma@xxxxxxxxx>
Date: Tue, 02 Aug 2005 14:16:07 -0700
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 02 Aug 2005 21:14:34 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <mailman.1122700301.23748@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20050730045452.D2F2F11AA@xxxxxxxxxxxxxxxxxxxxx> None None <mailman.1122700301.23748@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
Leendert van Doorn wrote:

Correcting the MILLISECS() and friends macros to return s_time_t instead
of ULL fixes this problem. The other changes are just to get rid of
redundant code and variables.


Thanks, I have an equivalent change in our internal tree. We also changed vpit->period and friends to count in s_time_t instead of milliseconds, to reduce some math on every tick.

Now that your patch is already upstream, I've rebased our remaining changes against your patch.

I'm working to make our internal tree visible to everyone so that if you run into such issues, you can check if a pending commit has already fixed it.

        -Arun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH] Broken timer macros breaks VMX, Arun Sharma <=