WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix the missing code path for emulating "mov <reg>,

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Fix the missing code path for emulating "mov <reg>, DR?"
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Mon, 11 Jul 2005 16:55:49 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 11 Jul 2005 08:54:50 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcWF9lXKyjnrHixjT8K1izY1ze78lA==
Thread-topic: [PATCH] Fix the missing code path for emulating "mov <reg>, DR?"
I found the code path for emulating "mov <reg>, DR?" could not be
reached, this patch fixed it.
-Xin

--- a/xen/arch/x86/traps.c      Sun Jul 10 19:16:40 2005
+++ b/xen/arch/x86/traps.c      Mon Jul 11 16:37:18 2005
@@ -840,6 +840,11 @@
             UNLOCK_BIGLOCK(v->domain);
             break;

+        default:
+            goto fail;
+        }
+        break;
+
     case 0x23: /* MOV <reg>,DR? */
         opcode = insn_fetch(u8, 1, eip);
         modrm_reg |= (opcode >> 3) & 7;
@@ -847,11 +852,6 @@
         reg = decode_register(modrm_rm, regs, 0);
         if ( do_set_debugreg(modrm_reg, *reg) != 0 )
             goto fail;
-        break;
-
-        default:
-            goto fail;
-        }
         break;

     case 0x30: /* WRMSR */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix the missing code path for emulating "mov <reg>, DR?", Li, Xin B <=