xen-devel

[Top] [All Lists]

[Xen-devel] Re: [PATCH] choose security model for ACM at built-time

from [Keir Fraser]

[Permanent Link][Original]

To:	aq <aquynh@xxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] choose security model for ACM at built-time
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Fri, 24 Jun 2005 17:13:04 +0100
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Fri, 24 Jun 2005 16:08:02 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<9cde8bff050624083345768b68@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<9cde8bff050624083345768b68@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx


On 24 Jun 2005, at 16:33, aq wrote:

At the moment, there is a problem with ACM: it is impossible to set
ACM security model at built-time, so even with ACM is chosen to build,
the default policy is NULL, which is useless.

This patch propose a solution to this problem: build process will
generate a header file (include/public/acm_policy.h) based on the
value set in xen/Makefile or at command-line, and gets acm.h included
it.


Looks fine, but:

Firstly, is the configured policy something that needs to be propagatedto user tools (i.e., should the generated header reside withininclude/public or should it be in include/xen)?

Secondly, you missed conditional inclusion of acm/acm.o into theALL_OBJS list in xen/Rules.mk. Also, the definition ofACM_USE_SECURITY_POLICY probably belongs more correctly in Rules.mkrather than the Makefile.


 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] choose security model for ACM at built-time, aq [Xen-devel] Re: [PATCH] choose security model for ACM at built-time, Keir Fraser <= [Xense-devel] Re: [PATCH] choose security model for ACM at built-time, aq

Previous by Date:	Re: [Xen-devel] Breakage in -unstable for Transmeta, Carl Holtje ;021;vcsg6;
Next by Date:	Re: [Xen-devel] Breakage in -unstable for Transmeta, Keir Fraser
Previous by Thread:	[Xen-devel] [PATCH] choose security model for ACM at built-time, aq
Next by Thread:	[Xense-devel] Re: [PATCH] choose security model for ACM at built-time, aq
Indexes:	[Date] [Thread] [Top] [All Lists]