xen-devel

[Top] [All Lists]

[Xen-devel] Re: [PATCH] x86_64 entry.S cleanup

from [Chris Wright]

[Permanent Link][Original]

To:	"Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] x86_64 entry.S cleanup
From:	Chris Wright <chrisw@xxxxxxxx>
Date:	Mon, 13 Jun 2005 22:41:09 -0700
Cc:	Chris Wright <chrisw@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 14 Jun 2005 05:40:18 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<7F740D512C7C1046AB53446D3720017304404F8B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<7F740D512C7C1046AB53446D3720017304404F8B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.6i

* Nakajima, Jun (jun.nakajima@xxxxxxxxx) wrote:
> Looks good.

Thanks for reviewing, Jun.

> I think you are talking about the different code path for
> do_hypervisor_callback, which does not do
> XEN_SAVE_UPCALL_MASK(%r11,%cl,EVENT_MASK. Looks like we don't need to do
> that any more. See Changes for
> linux-2.6.11-xen-sparse/arch/xen/i386/kernel/entry.S@xxxxx So we can
> remove that extra checking and the code saving the mask. Can you please
> update the patch?

Yeah, that's what I was talking about.  I had left behind a conditional
jump that wasn't really conditional anymore.  I'll update it and resend.

thanks,
-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] RE: [PATCH] x86_64 entry.S cleanup, Nakajima, Jun [Xen-devel] Re: [PATCH] x86_64 entry.S cleanup, Chris Wright <=

Previous by Date:	[Xen-devel] RE: [PATCH] x86_64 entry.S cleanup, Nakajima, Jun
Next by Date:	[Xen-devel] [PATCH] x86_64 entry.S cleanup - take 2, Chris Wright
Previous by Thread:	[Xen-devel] RE: [PATCH] x86_64 entry.S cleanup, Nakajima, Jun
Next by Thread:	[Xen-devel] [PATCH] x86_64 entry.S cleanup - take 2, Chris Wright
Indexes:	[Date] [Thread] [Top] [All Lists]