WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Fixing stack alignment in x86-64 Xen

To: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Fixing stack alignment in x86-64 Xen
From: Andi Kleen <ak@xxxxxx>
Date: Wed, 18 May 2005 16:06:18 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 18 May 2005 14:10:57 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7F740D512C7C1046AB53446D3720017304021C2C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> (Jun Nakajima's message of "Tue, 17 May 2005 19:25:46 -0700")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7F740D512C7C1046AB53446D3720017304021C2C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux)
"Nakajima, Jun" <jun.nakajima@xxxxxxxxx> writes:

> Long mode needs to align the stack on a 16-byte boundary. Recent changes
> to Xen broke the requirement, and x86-64 XenLinux stopped booting. The
> attached fixes the problem. 

Normally it should be only needed in user space for saving FP registers.
The kernel and Xen which should not do this probably don't need it.

Unless you save FP registers on the stack somewhere. Then I would
rather fix that place only.

At least the main linux kernel does not try to keep the stack
always 16byte aligned. There is even a gcc option to turn it off
and it saves some code (and probably stack) size.

-Andi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel