WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] VMX check in /xen/arch/x86/domain.c is invalid on x86-64

To: Arun Sharma <arun.sharma@xxxxxxxxx>
Subject: Re: [Xen-devel] VMX check in /xen/arch/x86/domain.c is invalid on x86-64 (at least AMD)
From: Jerone Young <jerone@xxxxxxxxx>
Date: Thu, 12 May 2005 00:58:05 -0500
Cc: Jerone Young <jyoung5@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 12 May 2005 05:57:40 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Knjpi7II2t6jhQoN3imkJO0MTX/UOza/15akr/1k0F8XPOltlX0t6ATDjyyQsw6onqMtNopLwjn9tHAz7NcxazaTteNJfsEut5USJICsxMUSD8sWzrquv03u8F2ThfaWuN4l1XebER7liXIoj1vKMFX1WrF3IqIE3WC4oxZAXzI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4282EE03.9080700@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <mailman.1115870256.14673@xxxxxxxxxxxxxxxxxxxx> <4282EE03.9080700@xxxxxxxxx>
Reply-to: Jerone Young <jerone@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Yes I am actually. Sorry guy. I got that one screwed up in my head.
Pressed the send button too quickly. Thanks for the respsonses though.

On 5/12/05, Arun Sharma <arun.sharma@xxxxxxxxx> wrote:
> Jerone Young wrote:
> > if (!(c->flags & ECF_VMX_GUEST))
> >         if ( ((c->cpu_ctxt.cs & 3) == 0) ||
> >              ((c->cpu_ctxt.ss & 3) == 0) )
> >                 return -EINVAL;
> >
> > This check in /xen/arch/x86/domain.c (line 394) is invalid for AMD
> > x86-64 as this field 1<<1 is a reserved field in the rflags (name for
> > 64bit eflags) that reads as 1. This can be found in the AMD x86-64
> > Programming manual vol 2 on page 65. Below is the code, I'm not sure how
> > to put an ifdef around since I'm not sure if Intel's EMT64 with VMX cpus
> > have the same rflag reserved (which if this check is correct they do)?
> > This helps break x86-64 building domU domains.
> >
> 
> It is a reserved bit on Intel as well. Look at:
> 
> VMCS_EFLAGS_RESERVED_1 and the IA-32 vol1 Fig 3-7.
> 
> Are you mixing up ctxt->user_regs.rflags and ctxt->flags in
> xc_linux_build.c?
> 
>         -Arun
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>