WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Guest boot loader support [1/2]

To: Mike Wray <mike.wray@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Guest boot loader support [1/2]
From: Jeremy Katz <katzj@xxxxxxxxxx>
Date: Thu, 14 Apr 2005 13:12:25 -0400
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 14 Apr 2005 17:14:55 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <425E5FF4.1070002@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1113448371.5078.50.camel@xxxxxxxxxxxxxx> <425E5FF4.1070002@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Attached patch replaces the previous one fixing things as described
below.

Signed-off-by: Jeremy Katz <katzj@xxxxxxxxxx

On Thu, 2005-04-14 at 13:20 +0100, Mike Wray wrote:
> - need to remove calls to exit from xend-called code
> - replace prints to stderr with logging
> - handle errors when calling external scripts

Error handling cleaned up and better use of logging instead of just
printing things.

> - it would be better to be able to remove the assumption that the first
>    device is the disk to boot from

Left this for the first pass.  If there's some agreement on my previous
suggestion of how to handle this, then that can easily be implemented on
top without really needing to be done to get the first pass in.  I think
a lot of uses right now are really only one vbd anyway.

> There are functions to manipulate the block device name in 
> xend/server/blkif.py.
> Probably better to use one of those.

I didn't actually find one that did what was needed for take the uname
to a filename, so I added one and use it both places I had the code.

Jeremy

Attachment: xen-blchanges-rev2.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel