Re: [Xen-devel] [PATCH] tools top level makefile cleanup

[Adam Heath <doogie@xxxxxxxxxxxxx>]

On Tue, 22 Mar 2005, Jerone Young wrote:

> I cleaned up the top level makefile in the tools directory. No major
> changes. Except I have it so that ioemmu is compiled only with x86_32.
>
> Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx>
>
> +all:
> +     @for subdir in $(SUBDIRS); do \
> +             $(MAKE) -C $$subdir $@ || exit -1; \
> +     done
> +
> +clean:
> +     @for subdir in $(SUBDIRS); do \
> +             $(MAKE) -C $$subdir $@ || exit -1; \
> +     done
> +
> +install:
> +     @for subdir in $(SUBDIRS); do \
> +             $(MAKE) -C $$subdir $@ || exit -1; \
> +     done

Don't do it like this.  make -j won't work.

Besides, don't use || exit.  Instead, use set -e.


-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel