WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore

To: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] make mrproper remove include/.asm-ignore
From: Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>
Date: Fri, 19 Nov 2004 09:16:18 +0000
Cc: "Rik van Riel" <riel@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxxx, Ian.Pratt@xxxxxxxxxxxx
Delivery-date: Fri, 19 Nov 2004 09:17:18 +0000
Envelope-to: xen+James.Bulpin@xxxxxxxxxxxx
In-reply-to: Your message of "Thu, 18 Nov 2004 20:03:35 GMT." <A95E2296287EAD4EB592B5DEEFCE0E9D122E64@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
> > When compiling multiple kernels in the same source tree, it 
> > is normal to run 'make mrproper' in-between builds.  This 
> > removes include/asm, but it doesn't remove include/.asm-ignore.
> > 
> > This leads to the main Makefile linking include/asm to the 
> > wrong directory and the second kernel build failing.  This 
> > little patch appears to fix that.

Hmm, I've looked at this a bit closer, and I'd like to clarify
why the patch is needed.

"make ARCH=xen mrproper" seems to delete everything OK.

Do you want it such that "make mrproper" (defaulting to i386)
cleans everything too? (seems reasonable).

I can apply the patch and include it in the changset we send
upstream.

Ian
  
> > 
> > --- linux-2.6.9/Makefile.xenness    2004-11-18 
> > 11:53:26.000000000 -0500
> > +++ linux-2.6.9/Makefile    2004-11-18 11:53:54.000000000 -0500
> > @@ -921,7 +921,7 @@ CLEAN_FILES +=  vmlinux System.map \
> >   MRPROPER_DIRS  += include/config include2
> >   MRPROPER_FILES += .config .config.old include/asm .version \
> >                     include/linux/autoconf.h include/linux/version.h \
> > -                  Module.symvers tags TAGS cscope*
> > +                  Module.symvers tags TAGS cscope* 
> > include/.asm-ignore
> > 
> >   # clean - Delete most, but leave enough to build external modules
> >   #
> > 
> > 
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: InterSystems CACHE FREE 
> > OODBMS DOWNLOAD - A multidimensional database that combines 
> > robust object and relational technologies, making it a 
> > perfect match for Java, C++,COM, XML, ODBC and JDBC. 
> > www.intersystems.com/match8 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.sourceforge.net/lists/listinfo/xen-devel
> > 
> > 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE
> FREE OODBMS DOWNLOAD - A multidimensional database that combines
> robust object and relational technologies, making it a perfect match
> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/xen-devel
 -=- MIME -=- 
> When compiling multiple kernels in the same source tree, it=20
> is normal to run 'make mrproper' in-between builds.  This=20
> removes include/asm, but it doesn't remove include/.asm-ignore.
>=20
> This leads to the main Makefile linking include/asm to the=20
> wrong directory and the second kernel build failing.  This=20
> little patch appears to fix that.

Thanks for pointing this out. I guess a cleaner way of doing this would
be to have an 'archmrproper' definition in our arch/xen/Makefile.

Perhaps I should just make archmrproper dependent on archclean and we
should be OK.

Ian=20
=20
>=20
> --- linux-2.6.9/Makefile.xenness      2004-11-18=20
> 11:53:26.000000000 -0500
> +++ linux-2.6.9/Makefile      2004-11-18 11:53:54.000000000 -0500
> @@ -921,7 +921,7 @@ CLEAN_FILES +=3D  vmlinux System.map \
>   MRPROPER_DIRS  +=3D include/config include2
>   MRPROPER_FILES +=3D .config .config.old include/asm .version \
>                     include/linux/autoconf.h include/linux/version.h \
> -                  Module.symvers tags TAGS cscope*
> +                  Module.symvers tags TAGS cscope*=20
> include/.asm-ignore
>=20
>   # clean - Delete most, but leave enough to build external modules
>   #
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE FREE=20
> OODBMS DOWNLOAD - A multidimensional database that combines=20
> robust object and relational technologies, making it a=20
> perfect match for Java, C++,COM, XML, ODBC and JDBC.=20
> www.intersystems.com/match8=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/xen-devel
>=20
>=20


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel



-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel